Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input can now use overwrite mode when toggled with insert key #735

Merged
merged 3 commits into from
Aug 28, 2023
Merged

input can now use overwrite mode when toggled with insert key #735

merged 3 commits into from
Aug 28, 2023

Conversation

mingsheng13
Copy link
Contributor

No description provided.

@mingsheng13
Copy link
Contributor Author

overwrite

@ArthurSonzogni
Copy link
Owner

Thank you very much! This looks very nice!

ArthurSonzogni
ArthurSonzogni requested changes Aug 28, 2023
View reviewed changes
Copy link
Owner

@ArthurSonzogni ArthurSonzogni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here are some comments:

After they are addressed, I will add a patch to add some test and update the CHANGELOG.

src/ftxui/component/input.cpp Show resolved Hide resolved
include/ftxui/component/component_options.hpp Outdated Show resolved Hide resolved
src/ftxui/component/input.cpp Outdated Show resolved Hide resolved
@mingsheng13
Copy link
Contributor Author

@ArthurSonzogni I've changed the codes. Could you please have a look :)

mingsheng13
mingsheng13 commented Aug 28, 2023
View reviewed changes
Copy link
Contributor Author

@mingsheng13 mingsheng13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ArthurSonzogni ArthurSonzogni merged commit 05c7bee into ArthurSonzogni:main Aug 28, 2023
6 checks passed
@mingsheng13 mingsheng13 deleted the Input-with-insert branch August 28, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSonzogni ArthurSonzogni ArthurSonzogni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingsheng13 @ArthurSonzogni